fix(plugins): implement the missing driver requirements in the concurrency test stub#1866
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. ThemacOS App Testsjob fails to compile:Introduced by #1864 (failing run).
Cause
PluginDatabaseDriverhas 12 requirements with no default implementation in its protocol extension, so every conformer has to implement all of them.ConcurrentStubPluginDriverimplements 10 and omits two:fetchTableMetadata(table:schema:)fetchDatabaseMetadata(_:)Every other driver stub in the test target already implements both, which is why this is the only stub that fails.
The build passes on Xcode 27 locally and fails on the toolchain CI uses, which is the same local-versus-CI conformance gap this repo has hit before. CI is the authority here: the two requirements really are unsatisfied.
Fix
Implement the two missing requirements on the stub, matching what the sibling stubs already return (
PluginTableMetadata(tableName:)andPluginDatabaseMetadata(name:)).No production code changes, and no CHANGELOG entry: this is a test-only build fix with no user-facing behaviour.
Verification
PluginDriverAdapterConcurrencyTestscompiles and its 3 tests pass.swiftlint lint --strictclean.